Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Handle CERT_HAS_EXPIRED error #1299

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Feat: Handle CERT_HAS_EXPIRED error #1299

merged 2 commits into from
Jun 21, 2024

Conversation

dennypradipta
Copy link
Contributor

@dennypradipta dennypradipta commented Jun 21, 2024 •
edited
Loading

Monika Pull Request (PR)

What feature/issue does this PR add

This PR handles CERT_HAS_EXPIRED error #1298

How did you implement / how did you fix it

  1. Map the CERT_HAS_EXPIRED to status code 18

How to test

Use this config:

probes:
  - id: '1'
    name: 'Coding Horror'
    description: 'Probe to check Coding Horror blog'
    interval: 10 # in seconds (every 10 minutes)
    requests:
      - method: GET
        url: 'https://expired.badssl.com'
    alerts: 
      - assertion: response.status != 200
        message: Status not 200

image

sapiderman
sapiderman approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@sapiderman sapiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dennypradipta dennypradipta linked an issue Jun 21, 2024 that may be closed by this pull request
Handle CERT_HAS_EXPIRED errors in HTTP Prober #1298
Closed
@dennypradipta dennypradipta merged commit d5564bf into main Jun 21, 2024
5 checks passed
@raosan raosan deleted the story/1298 branch June 21, 2024 09:53
sapiderman pushed a commit to sapiderman/monika that referenced this pull request Jun 25, 2024
@dennypradipta @sapiderman
Feat: Handle CERT_HAS_EXPIRED_ERROR (hyperjumptech#1299)
83d7e41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapiderman sapiderman sapiderman approved these changes

@kevinhermawan kevinhermawan kevinhermawan approved these changes

@nicnocquee nicnocquee Awaiting requested review from nicnocquee

@raosan raosan Awaiting requested review from raosan

@ilmiawan ilmiawan Awaiting requested review from ilmiawan

@haricnugraha haricnugraha Awaiting requested review from haricnugraha

@kevin-hyperjump kevin-hyperjump Awaiting requested review from kevin-hyperjump

@lukman7788 lukman7788 Awaiting requested review from lukman7788

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle CERT_HAS_EXPIRED errors in HTTP Prober
3 participants
@dennypradipta @sapiderman @kevinhermawan